Add support for the MESSAGE_LOST event#581
Closed
MiguelCompany wants to merge 13 commits intoros2:masterfrom
Closed
Add support for the MESSAGE_LOST event#581MiguelCompany wants to merge 13 commits intoros2:masterfrom
MiguelCompany wants to merge 13 commits intoros2:masterfrom
Conversation
Fast-DDS (and rmw_fastrtps_cpp) don't really support this right now, but having it in the list here allows RViz2 to start up. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
clalancette
approved these changes
Feb 10, 2022
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI. Thanks @MiguelCompany !
Contributor
|
CI:
|
fujitatomoya
approved these changes
Feb 10, 2022
Collaborator
Author
|
@clalancette this test will fail unless we have a correct implementation for The only way to push this foward I can think of is to disable MESSAGE_LOST support on the CI, by putting this inside a Let me know what you think. |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Merged
Collaborator
Author
|
Closed in favor of #583 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #580 and adds proper support for MESSAGE_LOST event.
The interfaces are already present in Fast-DDS, but the listener callback is currently never called.
This means the RMW will behave as if messages are never lost, until we implement on_sample_lost on Fast DDS v2.6.0.