Add in fake support for the MESSAGE_LOST event.#580
Closed
clalancette wants to merge 1 commit intomasterfrom
Closed
Add in fake support for the MESSAGE_LOST event.#580clalancette wants to merge 1 commit intomasterfrom
clalancette wants to merge 1 commit intomasterfrom
Conversation
Fast-DDS (and rmw_fastrtps_cpp) don't really support this right now, but having it in the list here allows RViz2 to start up. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
fujitatomoya
approved these changes
Feb 10, 2022
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
makes sense to me.
Collaborator
|
@clalancette @fujitatomoya I've just created #581 which adds support for MESSAGE_LOST. |
Contributor
Author
|
Closing in favor of #581 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast-DDS (and rmw_fastrtps_cpp) don't really support this right
now, but having it in the list here allows RViz2 to start up.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
@MiguelCompany @EduPonz FYI