Merged
Conversation
Member
|
I doubt this will work on Windows and maybe not even on OS X or Linux with clang. |
Member
|
Maybe CMake or our code (ignore if missing) is filtering it out? I don't think pthread is a valid library target on Windows. |
5e22443 to
83bad2b
Compare
Member
Author
|
I wrapped it in a conditional for Since we use |
Member
|
Sounds good to me +1 |
Contributor
|
interesting, I wonder what happens with a Windows FastRTPS-only build. |
Contributor
|
I confirmed on a Xenial VM that pthread linkage is an issue and that this fixes the build (for rmw_fastrtps_cpp yet, the rest of the workspace is building now). +1 |
mauropasse
pushed a commit
to mauropasse/rmw_fastrtps
that referenced
this pull request
May 25, 2021
…ecutor Mauro/rebase add events executor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With only FastRTPS several examples fail to link since it seems to use
pthreadbut doesn't export it (at least on Xenial, maybe also with other RMW impl. but currently I only have FastRTPS).