Merged
Conversation
This was referenced Aug 21, 2017
Merged
mikaelarguedas
approved these changes
Aug 22, 2017
Member
mikaelarguedas
left a comment
There was a problem hiding this comment.
lgtm, I pushed 25ee8a3 directly feel free to revert it if it was intentional
25ee8a3 to
f2d5b1f
Compare
Member
Author
Thanks for the fix. I squashed that commit into the second commit. Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #145 additionally exposing the publishers and subscribers of topics as well as services.