Merged
Conversation
wjwwood
approved these changes
Aug 18, 2017
Member
wjwwood
left a comment
There was a problem hiding this comment.
+1, makes sense to me.
I always imagined the API added here would be in a separate package, but I can't think of a reason it needs to be at this point.
3965d67 to
c3c533f
Compare
c3c533f to
c452522
Compare
Member
Author
This was referenced Aug 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an example how to expose native handles from a rmw implementation. It only exposes the
eprosima::fastrtps::Participantbut other handles could be supported in a similar fashion. The patch demonstrate how this is possible and that it can be achieved by each rmw implementation without requiring any changes in thermwinterface.When the function is being used with a different rmw implementation at runtime
get_participantreturnsNULL.In order to try this feature I modified the
talkerin thedemo_nodes_cpppackage. The changes are straight forward. Only getting from the C++Nodeto thermw_node_tis not "very pretty":package.xmlCMakeLists.txttalker.cpp