Support for deadline, lifespan and liveliness qos#88
Merged
eboasson merged 3 commits intoros2:masterfrom Jan 31, 2020
Merged
Conversation
added 2 commits
January 20, 2020 16:21
This commit adds support for liveliness, lifespan and deadline missed qos in rmw, and it adds event support in rmw_wait that is required for these qos policies to work correctly.
… for qos getter and setter
eboasson
approved these changes
Jan 23, 2020
Collaborator
eboasson
left a comment
There was a problem hiding this comment.
Looks good to me.
It behaves as expected for me on macOS and Ubuntu and I'm willing to "risk it" with respect to Windows if no one has any objections.
…gered when a writer becomes not-alive and unregisters itself
Collaborator
|
This fixes makes all the rcl tests go green for me locally on macOS in combination with eclipse-cyclonedds/cyclonedds#378 and has no adverse affects that I can see (either from code inspection or building/running locally) without that PR on Cyclone applied. Merging. |
eboasson
pushed a commit
that referenced
this pull request
Mar 12, 2020
* Events and liveliness/lifespan/deadline qos support This commit adds support for liveliness, lifespan and deadline missed qos in rmw, and it adds event support in rmw_wait that is required for these qos policies to work correctly. * Removed redundant empty check in rmw_wait, fix duration 0 vs infinity for qos getter and setter * Disabled auto-dispose so that deadline-missed on reader is still triggered when a writer becomes not-alive and unregisters itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for events in
rmw_wait, which is required for the lifespan and deadline qos to work properly. I've also added code for setting the deadline, lifespan and liveliness qos policies increate_readwrite_qos. And when getting qos properties inget_readwrite_qos, an infinite duration is no longer returned as 0, astest_get_actual_qos__rmw_cyclonedds_cppexpects the value to be >= MAX_INT32