Add tracepoint for publish/subscribe serialized message#485
Merged
mjcarroll merged 9 commits intoros2:rollingfrom Apr 5, 2024
Merged
Add tracepoint for publish/subscribe serialized message#485mjcarroll merged 9 commits intoros2:rollingfrom
mjcarroll merged 9 commits intoros2:rollingfrom
Conversation
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
eboasson
reviewed
Mar 13, 2024
Co-authored-by: eboasson <eb@ilities.com> Signed-off-by: h-suzuki-isp <146712054+h-suzuki-isp@users.noreply.github.com>
Contributor
|
@mjcarroll /assign along with ros2/rmw_fastrtps#748 |
christophebedard
approved these changes
Mar 28, 2024
Member
christophebedard
left a comment
There was a problem hiding this comment.
This looks good to me. @eboasson or @mjcarroll do you want to take a(nother) look?
Contributor
Author
|
@eboasson @mjcarroll (Cc: @christophebedard ) |
mjcarroll
requested changes
Apr 4, 2024
Member
mjcarroll
left a comment
There was a problem hiding this comment.
Mostly good, one nit and I would like clarification on the impact of the API change.
| if (message_info) { | ||
| message_info_from_sample_info(info, message_info); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Nit: unnecessary whitespace change
Member
|
Note that CI was run here: ros2/rclcpp#2448 (comment) |
Signed-off-by: h-suzuki-isp <h-suzuki@isp.co.jp>
Member
|
I think we can probably skip CI since the only new change is a new blank line. |
mjcarroll
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please, refer to ros2/rclcpp#2448 .
I have added the following trace points.
__rmw_publish_serialized_message()_take_serialized_message()