Conversation
Yeah, you can just use the bot. Once this has been approved, CI has been run, and merged, you can ask the bot to backport it for you with a |
clalancette
left a comment
There was a problem hiding this comment.
Looks reasonable to me with green CI.
|
Thank you for the info, I'll try that after merging. CI results:
Should I run macOS too? |
No, but you should use https://ci.ros2.org/job/ci_launcher/ to make sure to run CI on our default platforms. |
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
f8954d9 to
8bd04d5
Compare
|
Coming back to this PR, and trying to get it merged. I rebased it on top of
ETA: I stopped the ci_linux-aarch64 plan since |
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
afa5055) Signed-off-by: Andrea Sorbini <asorbini@rti.com> Signed-off-by: Taxo Rubio <trubio@rti.com>
* backport: Add support for listener callbacks (#76) (d4330cc) * Add support for listener callbacks. * Fix wrong debug assertion when converting DDS_Duration values * Clarify interactions between count_unread_samples() and take_next() * Notify on changed matched status Signed-off-by: Christopher Wecht <cwecht@mailbox.org> Signed-off-by: Andrea Sorbini <asorbini@rti.com> Signed-off-by: Taxo Rubio <trubio@rti.com> * backport: Conditional internal API access to support Connext 7+ (#121) (afa5055) Signed-off-by: Andrea Sorbini <asorbini@rti.com> Signed-off-by: Taxo Rubio <trubio@rti.com> * style: Fixed header inclusion order Signed-off-by: Taxo Rubio <trubio@rti.com> --------- Signed-off-by: Christopher Wecht <cwecht@mailbox.org> Signed-off-by: Andrea Sorbini <asorbini@rti.com> Signed-off-by: Taxo Rubio <trubio@rti.com> Co-authored-by: Andrea Sorbini <asorbini@rti.com>
The current version of rmw_connextdds does not support Connext 7+ because of an internal API change.
This PR wraps the "troubling" call with an
#ifchecking macroRTI_DDS_VERSION_MAJOR, which is defined by the Connext Pro headers.I have created a branch to backport the fix to
humblebut I noticed there seems to be a "backporting bot" now, so I'm not sure if I should create a separate PR, or if we can use the bot to automatically backport this one. I think the commit should apply cleanly on top ofhumbletoo.