This repository was archived by the owner on Jun 21, 2023. It is now read-only.
wrap Connext libraries in --no-as-needed#188
Merged
dirk-thomas merged 1 commit intomasterfrom Jul 5, 2016
Merged
Conversation
Member
|
I'm trying out a build on my Linux VM with this pr and ament/ament_cmake#75, but do I need ros2/rcl#61 too? |
Member
Author
|
No, the With these two patches it should compile and link but the runtime behavior of Connext dynamic is still broken. Testing a patch for that right now. |
Member
Author
|
At least it doesn't seem to break anything with the normal builds: |
Member
|
I'm retrying the build on my VM now. |
Member
|
Works for me. |
Member
Author
|
Does that imply a +1 on the ament_cmake PR too? |
Member
|
Yeah, I think it's good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #173, requires ament/ament_cmake#75.