Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

export --no-as-needed link flag#173

Closed
dirk-thomas wants to merge 1 commit intomasterfrom
export_link_flags
Closed

export --no-as-needed link flag#173
dirk-thomas wants to merge 1 commit intomasterfrom
export_link_flags

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas commented Jun 8, 2016

Export the linker flags for the Connext packages to address ros2/rcl#55 (comment) (as documented in the Connext Platform notes).

http://ci.ros2.org/job/ci_linux/1419/

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jun 8, 2016
@dirk-thomas dirk-thomas self-assigned this Jun 8, 2016
This was referenced Jun 8, 2016
Merged
Closed
Closed
Closed
@dirk-thomas dirk-thomas added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Jun 8, 2016
@dhood dhood mentioned this pull request Jun 22, 2016
Merged
@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jun 29, 2016

Maybe this needs to be resurrected? I just ran into this:

==> '. /home/william/ros2_ws/build_isolated/intra_process_demo/cmake__build.sh && /usr/bin/make -j1' in '/home/william/ros2_ws/build_isolated/intra_process_demo'
[  4%] Built target image_view_node__rmw_fastrtps_cpp
[  9%] Built target image_pipeline_with_two_image_view__rmw_fastrtps_cpp
[ 14%] Built target watermark_node__rmw_fastrtps_cpp
[ 19%] Built target image_pipeline_with_two_image_view__rmw_connext_cpp
[ 21%] Linking CXX executable two_node_pipeline__rmw_fastrtps_cpp
/home/william/rti_connext_dds-5.2.3/lib/x64Linux3gcc4.8.2/libnddscored.so: undefined reference to `dlclose'
/home/william/rti_connext_dds-5.2.3/lib/x64Linux3gcc4.8.2/libnddscored.so: undefined reference to `dlsym'
/home/william/rti_connext_dds-5.2.3/lib/x64Linux3gcc4.8.2/libnddscored.so: undefined reference to `dlopen'
/home/william/rti_connext_dds-5.2.3/lib/x64Linux3gcc4.8.2/libnddscored.so: undefined reference to `dlerror'
collect2: error: ld returned 1 exit status
CMakeFiles/two_node_pipeline__rmw_fastrtps_cpp.dir/build.make:122: recipe for target 'two_node_pipeline__rmw_fastrtps_cpp' failed
make[2]: *** [two_node_pipeline__rmw_fastrtps_cpp] Error 1
CMakeFiles/Makefile2:439: recipe for target 'CMakeFiles/two_node_pipeline__rmw_fastrtps_cpp.dir/all' failed
make[1]: *** [CMakeFiles/two_node_pipeline__rmw_fastrtps_cpp.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2

Which I believe is the same class of issue that you reported in your comment: ros2/rcl#55 (comment)

@dirk-thomas
Copy link
Copy Markdown
Member Author

dirk-thomas commented Jun 29, 2016

I triggered http://ci.ros2.org/job/ci_linux/1598/ after the recent rebases.

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jun 30, 2016

Something went wrong in the ci job. It looks like all of the connext jobs failed with some sort of issue getting the default participant QoS.

@dirk-thomas
Copy link
Copy Markdown
Member Author

dirk-thomas commented Jun 30, 2016

Nothing wrong in the CI job. I am pretty sure the same is happening on local builds.

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jun 30, 2016

Sorry, I meant something is wrong with the branch (which was tested in the ci job you started).

@dirk-thomas
Copy link
Copy Markdown
Member Author

dirk-thomas commented Jun 30, 2016

rmw_connext/rmw_connext_shared_cpp/src/shared_functions.cpp

Line 260 in fe273cb

DDS_ReturnCode_t status = dpf_->get_default_participant_qos(participant_qos);
returns DDS_RETCODE_BAD_PARAMETER.

I don't think that we can apply these link flags "globally".

@dirk-thomas dirk-thomas mentioned this pull request Jul 1, 2016
Merged
@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jul 6, 2016

Should this be closed now?

@dirk-thomas dirk-thomas closed this Jul 6, 2016
@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jul 6, 2016

I think it should based on #188's description, closing.

@dirk-thomas dirk-thomas deleted the export_link_flags branch July 6, 2016 19:46
@dirk-thomas dirk-thomas removed the in progress Actively being worked on (Kanban column) label Jul 6, 2016
@mikaelarguedas mikaelarguedas mentioned this pull request Dec 11, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@dirk-thomas dirk-thomas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dirk-thomas @wjwwood