[xtypes] publisher / subscriber segfaults#12
Conversation
|
This patch fixed the current segfault. But we have to revisit the type support identifiers and restore the checking functionality it should provide without requiring string comparison. I have created a separate ticket since that will likely involve more effort: ros2/ros2#30 |
There was a problem hiding this comment.
Could you replace this with strncmp?
There was a problem hiding this comment.
What would you suggest to pass as n? Because if I use strlen to determine the length the problem would be same if the string wouldn't have a terminating zero character.
There was a problem hiding this comment.
We know the length of the identifier (e.g. rosidl_typesupport_introspection_cpp::typesupport_introspection_identifier), we could just use that.
There was a problem hiding this comment.
Updated to use strncmp(A, B, strlen(B)). Thanks.
878804d to
e879d1a
Compare
|
+1 |
|
+1 |
[xtypes] publisher / subscriber segfaults
Example to reproduce: userland unit test
test_(publisher|subscriber)__rmw_connext_xtypes_dynamic_cpp