Skip to content

Fix "function declaration isn't a prototype" warnings#53

Merged
esteve merged 1 commit intomasterfrom
fix-prototype-warnings
Feb 4, 2016
Merged

Fix "function declaration isn't a prototype" warnings#53
esteve merged 1 commit intomasterfrom
fix-prototype-warnings

Conversation

@esteve
Copy link
Copy Markdown
Member

@esteve esteve commented Feb 4, 2016

Fix "function declaration isn't a prototype" warnings

@esteve esteve self-assigned this Feb 4, 2016
@esteve esteve added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 4, 2016
@esteve
Copy link
Copy Markdown
Member Author

esteve commented Feb 4, 2016

@jacquelinekay
Copy link
Copy Markdown
Contributor

Looks fine to me. Where was the warning coming from?

@esteve
Copy link
Copy Markdown
Member Author

esteve commented Feb 4, 2016

From rclpy. GCC reports it as a warning, but it actually causes a linking conflict, so when I called rmw_get_implementation_identifier(), I got a bogus string instead of the real thing. Properly declaring that function as a prototype fixed the problem.

esteve added a commit that referenced this pull request Feb 4, 2016
Fix "function declaration isn't a prototype" warnings
@esteve esteve merged commit c87cf06 into master Feb 4, 2016
@esteve esteve deleted the fix-prototype-warnings branch February 4, 2016 21:51
@esteve esteve removed the in review Waiting for review (Kanban column) label Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants