RMW_DURATION_INFINITE constant - use in QoS API contracts#255
RMW_DURATION_INFINITE constant - use in QoS API contracts#255emersonknapp wants to merge 3 commits intoros2:masterfrom
Conversation
|
Closed by unintentional language in another PR comment - still working on this |
|
I am actively working on this right now (for any interested parties). I've gathered more information to illustrate how the RMW API is currently incomplete. The following values are gathered from
"DDS IDL PSM Constant" above refers to the values laid out in Section 2.3.3 of the DDS 1.4 spec. From my understanding this PSM is meant to provide common interfaces for programming languages. There are separate docs available as well:
Based on the above information, the two implementations are providing values that are neither consistent with each other or guidelines from the specification - seems like we just have exposed implementation details. My next step is an updated API proposal, which will come with coupled prototype PRs for the RMW implementations. Interesting note: the IDL PSM specifies Durations as: But we use exclusively unsigned values within the RMW API. |
4494d8e to
6ce82d7
Compare
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
da71ce4 to
5faaf81
Compare
|
Closing this in favor of #301 for now |
Resolves #210
Depends on #298 (which resolves #215)
Create explicit
RMW_DURATION_INFINITEconstant for use in requesting/offering QoS policies with durations, to be used as the default value instead of 0. Enforce using these values in the API contract.Linked PRs:
Note: non-linked followups:
Testing
Gist:
Build: