Merged
Conversation
Clarify pre- and post-conditions. Clean up. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
reviewed
Jun 23, 2020
ivanpauno
approved these changes
Jun 23, 2020
Blast545
approved these changes
Jun 23, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Author
|
@ivanpauno @Blast545 I just constrained the API a bit more e.g. you cannot copy from a zero-initialized source (it's redundant w/ finalization). PTAL. |
This was referenced Jun 23, 2020
ivanpauno
approved these changes
Jun 23, 2020
Author
|
CI up to
|
Blast545
approved these changes
Jun 23, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
fujitatomoya
approved these changes
Jun 24, 2020
ivanpauno
approved these changes
Jun 24, 2020
Author
|
One last sanity CI run after API contract updates:
|
Author
|
Alright going in! |
ahcorde
pushed a commit
that referenced
this pull request
Oct 13, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 13, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify pre- and post-conditions. Clean up a bit.