Methods to retrieve matched counts on publisher and subscriber#155
Merged
Methods to retrieve matched counts on publisher and subscriber#155
Conversation
This was referenced Nov 12, 2018
wjwwood
reviewed
Nov 12, 2018
jacobperron
approved these changes
Nov 13, 2018
Member
jacobperron
left a comment
There was a problem hiding this comment.
Other than two typos, LGTM
0c61d27 to
f11eac0
Compare
This was referenced Nov 26, 2018
Member
Author
|
CI:
|
Co-Authored-By: mjcarroll <michael@openrobotics.org>
Member
Author
|
Rerun CI after all changes:
|
Member
Author
|
Once more with rebased
|
|
This pull request enables the feature |
Collaborator
|
@AndreasR30 probably #331 this is what you need? you are very much welcome for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides an API for retrieving the number of matched publishers to a subscription and vice-versa. It is a method to be used with forthcoming additions in creating a port of
SubscriberStatusCallback(from ROS 1, see: https://docs.ros.org/api/roscpp/html/namespaceros.html#ac61b99a2913cd421fb915395a67e71a1) for ROS2.This is different from the existing graph methods, as it should interact directly with a publisher or subscription to retrieve the matched count.
Requires changes in: