feat: Added marco to disable deprecation warnings#210
feat: Added marco to disable deprecation warnings#210christophebedard merged 1 commit intoros2:rollingfrom
Conversation
christophebedard
left a comment
There was a problem hiding this comment.
I think it's fine to add this, but I just have a few minor comments/suggestions.
| target_link_libraries(test_shared_library ${PROJECT_NAME}) | ||
| endif() | ||
|
|
||
| add_library(dummy_compile_test test/test_compile_warnings.cpp) |
There was a problem hiding this comment.
Could we make sure to make the deprecation warning an error so that building actually fails if the macro doesn't work?
There was a problem hiding this comment.
Added "-Werror" for this target
There was a problem hiding this comment.
ah, -Werror doesn't work on Windows. Maybe /WX?
There was a problem hiding this comment.
@jmachowinski the compile option needs to be different for Windows
There was a problem hiding this comment.
something like:
if(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
target_compile_options(dummy_compile_test PRIVATE "/WX")
else()
target_compile_options(dummy_compile_test PRIVATE "-Werror")
endif()There was a problem hiding this comment.
This should be fixed now, if only the CI would run....
b380866 to
09b0ba0
Compare
fujitatomoya
left a comment
There was a problem hiding this comment.
good to go. @christophebedard i will leave this to you.
|
Pulls: #210
|
|
Triggering a ci_linux_clang_libcxx job with the same config:
|
ef4e229 to
b36cfa2
Compare
|
Pulls: #210
|
|
Another ci_linux_clang_libcxx job with the same config:
|
|
Pulls: #210
|
Helper for suppressing compile warning. Useful for testing deprecated APIs etc. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
|
CI is green, note, I restarted the Windows CI after the force push that repaired the windows macro. |
Helper for suppressing compile warning. Useful for testing deprecated APIs etc.