time_until_next_call returns max if timer is canceled#907
Closed
mauropasse wants to merge 1 commit intoros2:masterfrom
Closed
time_until_next_call returns max if timer is canceled#907mauropasse wants to merge 1 commit intoros2:masterfrom
mauropasse wants to merge 1 commit intoros2:masterfrom
Conversation
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
fujitatomoya
approved these changes
Mar 2, 2022
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
it would be nicer if we have doc section aligned with rclcpp, but lgtm.
Author
|
#910 did the job, thanks @fujitatomoya ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR ros2/rcl#963 changes
rcl_timer_get_time_until_next_callto returnRCL_RET_TIMER_CANCELEDif timer was canceled.Here in
rclpywe'll returnstd::numeric_limits<int64_t>::max()ontime_until_next_callif timer was canceled.Signed-off-by: Mauro Passerino mpasserino@irobot.com