Fix segfault by adding __enter__ and __exit__ to Waitable#761
Merged
Conversation
Also make QoS event waitable use it. This fixes a crash when another thread is spinning on a destroyed subscription using cyclonedds. Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
This was referenced Apr 7, 2021
Contributor
Author
|
CI (build:
|
mjeronimo
approved these changes
Apr 7, 2021
Contributor
|
As an FYI, I was able to reproduce the problem with the rqt_console plugin, and this seems to solve it for me. |
Contributor
Contributor
Author
mjeronimo
pushed a commit
to ros-visualization/rqt_topic
that referenced
this pull request
Apr 7, 2021
ros2/rclpy#761 fixes this issue. Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Contributor
Author
|
2 approvals and green CI, merging 🎉 |
clalancette
pushed a commit
to ros-visualization/rqt_topic
that referenced
this pull request
Apr 29, 2021
ros2/rclpy#761 fixes this issue. Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Contributor
|
@Mergifyio backport foxy |
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
Also make QoS event waitable use it. This fixes a crash when another thread is spinning on a destroyed subscription using cyclonedds. Signed-off-by: Shane Loretz <sloretz@openrobotics.org> (cherry picked from commit a75529d)
Contributor
✅ Backports have been createdDetails
|
tfoote
added a commit
that referenced
this pull request
Sep 1, 2022
Fix segfault by adding __enter__ and __exit__ to Waitable (backport #761)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #760
Also make QoS event waitable use it. This fixes a crash when another
thread is spinning on a destroyed subscription using cyclonedds.
I was never able to reproduce the crash with
rqt_console, but I can confirm it fixes the crash with this MRE #760 (comment)