Skip to content

Revert "Create a default warning for qos incompatibility"#543

Merged
nuclearsandwich merged 1 commit intomasterfrom
revert-536-emersonknapp/default-incompatible-qos-callback
Apr 16, 2020
Merged

Revert "Create a default warning for qos incompatibility"#543
nuclearsandwich merged 1 commit intomasterfrom
revert-536-emersonknapp/default-incompatible-qos-callback

Conversation

@nuclearsandwich
Copy link
Copy Markdown
Member

@nuclearsandwich nuclearsandwich commented Apr 16, 2020

Reverts #536 until test failures in ros2cli can be addressed.

FYI @ivanpauno as the reviewer of #536.

@nuclearsandwich nuclearsandwich merged commit d1c8f4d into master Apr 16, 2020
@nuclearsandwich nuclearsandwich deleted the revert-536-emersonknapp/default-incompatible-qos-callback branch April 16, 2020 03:13
mm318 added a commit to ross-desmond/rclpy that referenced this pull request Apr 16, 2020
@mm318
Revert "Revert "Create a default warning for qos incompatibility" (ro…
6622fd3 
…s2#543)"

This reverts commit d1c8f4d.
@mm318 mm318 mentioned this pull request Apr 16, 2020
Merged
@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Apr 16, 2020

Thanks for reverting @nuclearsandwich !

mm318 added a commit to ross-desmond/rclpy that referenced this pull request Apr 16, 2020
@mm318
Revert "Revert "Create a default warning for qos incompatibility" (ro…
b47160d 
…s2#543)"

This reverts commit d1c8f4d.

Signed-off-by: Miaofei <miaofei@amazon.com>
mm318 added a commit to ross-desmond/rclpy that referenced this pull request Apr 17, 2020
@mm318
Revert "Revert "Create a default warning for qos incompatibility" (ro…
a988c01 
…s2#543)"

This reverts commit d1c8f4d.

Signed-off-by: Miaofei <miaofei@amazon.com>
ivanpauno pushed a commit that referenced this pull request Apr 17, 2020
@mm318
Revert "Revert "Create a default warning for qos incompatibility"" (#544
b8209da 
)

* Revert "Revert "Create a default warning for qos incompatibility" (#543)"

This reverts commit d1c8f4d.

Signed-off-by: Miaofei <miaofei@amazon.com>

* remove warning message from failing to register default callback

Signed-off-by: Miaofei <miaofei@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nuclearsandwich @ivanpauno @emersonknapp