Skip to content

Fix test_action_client failures#471

Merged
ivanpauno merged 1 commit intomasterfrom
ivanpauno/fix-test-action-client
Dec 5, 2019
Merged

Fix test_action_client failures#471
ivanpauno merged 1 commit intomasterfrom
ivanpauno/fix-test-action-client

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno commented Dec 5, 2019

ros2/rcl#541 triggered some failures in CI, though the problem was that the test wasn't creating an status publisher.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Dec 5, 2019
@ivanpauno ivanpauno requested a review from jacobperron December 5, 2019 13:16
@ivanpauno ivanpauno self-assigned this Dec 5, 2019
@ivanpauno
Copy link
Copy Markdown
Member Author

ivanpauno commented Dec 5, 2019

  • Linux Build Status
  • Arch Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Copy Markdown
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That explains... LGTM!

@ivanpauno ivanpauno merged commit 9a4471c into master Dec 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-test-action-client branch December 5, 2019 17:18
@jacobperron
Copy link
Copy Markdown
Member

Glad you found the real issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in review Waiting for review (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants