should also check if action status publisher is ready.#541
Merged
ivanpauno merged 3 commits intoros2:masterfrom Nov 29, 2019
Merged
Conversation
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Collaborator
Author
|
this is an easy fix, could you take a look at it? |
ivanpauno
approved these changes
Nov 28, 2019
Member
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM!
CI:
- Linux
- Linux-aarch64
- macOS
- Windows
Member
|
Merging! Thanks for the fix @fujitatomoya ! |
This was referenced Dec 4, 2019
ralph-lange
pushed a commit
to micro-ROS/rcl
that referenced
this pull request
Dec 10, 2019
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current action client code just checks if feedback publisher is ready on action server side. it should also check if status publisher is ready on action server side.