enable/disable rosout logging in each node individually#469
enable/disable rosout logging in each node individually#469ivanpauno merged 3 commits intoros2:masterfrom
Conversation
Signed-off-by: Barry Xu <Barry.Xu@sony.com>
Signed-off-by: Barry Xu <Barry.Xu@sony.com>
|
Please review this PR. |
Signed-off-by: Barry Xu <Barry.Xu@sony.com>
|
I have updated test codes based on pytest. |
|
LGTM |
Failures are all unrelated, and being fixed by #471. |
|
Going in! Thanks for the contribution @Barry-Xu-2018 ! |
| ) | ||
|
|
||
| node.get_logger().info('SOMETHING') | ||
| executor.spin_once(timeout_sec=1) |
There was a problem hiding this comment.
@ivanpauno (tagging you because you reviewed it), watch out for things like this. It's really fragile, we're seeing this test fail a lot either due to the timeout before the event or because spinning once does not guarantee that the event you wanted handled was the one that would be handled...
There was a problem hiding this comment.
There was a problem hiding this comment.
@fujitatomoya if you're not planning to work on a fix in a near future, let me know and I will work on it. Thanks!
There was a problem hiding this comment.
i think i can work on this early next week, but if you already have idea, you can go ahead.
There was a problem hiding this comment.
Thank you for pointing out my mistake. I will fix it.
It's my fault. I will fix this problem tomorrow in #546.
There was a problem hiding this comment.
No worries, I wasn't trying to call anyone out, just wanted to point it out before I forgot and explain why it is fragile.
This is following PR for ros2/rcl#532.
Provide option to enable/disable rosout logging for rclpy.
Related issue is ros2/rcl#510.
There are 2 commits. One is for implementation. The other is for test codes.
There is a problem on test. Test codes needs python3-parameterized package.
'python3-parameterized' package is not supported currently in python test of ros2.
Whether do we can use 'python3-parameterized' this time?
If yes, do I need to update other repositories? (such as rosdistro, ros2 CI or some document) Not very clear about these steps.