Skip to content

Remove deprecated QoS functionality#431

Merged
jacobperron merged 1 commit intomasterfrom
jacob/remove_deprecated_qos
Sep 18, 2019
Merged

Remove deprecated QoS functionality#431
jacobperron merged 1 commit intomasterfrom
jacob/remove_deprecated_qos

Conversation

@jacobperron
Copy link
Copy Markdown
Member

Existing warnings are replaced with a new exception, InvalidQoSProfileException.

Resolves #430

Existing warnings are replaced with a new exception, InvalidQoSProfileException.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (with green CI)

@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Sep 18, 2019

@jacobperron jacobperron merged commit 1e10707 into master Sep 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/remove_deprecated_qos branch September 18, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated functionality post-Dashing

2 participants