Skip to content

Fix Node's reference to executor#275

Merged
jacobperron merged 1 commit intomasterfrom
fix_node_executor_prop
Feb 13, 2019
Merged

Fix Node's reference to executor#275
jacobperron merged 1 commit intomasterfrom
fix_node_executor_prop

Conversation

@jacobperron
Copy link
Copy Markdown
Member

@jacobperron jacobperron commented Feb 13, 2019

Previously, if a Node was added to an Executor using the executors add_node method, then the nodes executor property would return None.

Previously, if a `Node` was added to an `Executor` using the executors `add_node` method, then nodes `executor` property would return `None`.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron requested a review from sloretz February 13, 2019 01:27
@jacobperron jacobperron self-assigned this Feb 13, 2019
@jacobperron jacobperron added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 13, 2019
Copy link
Copy Markdown
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and changes look good, but don't have a whole lot of context for the change.

@jacobperron
Copy link
Copy Markdown
Member Author

Looks reasonable and changes look good, but don't have a whole lot of context for the change.

As part of the ActionServer, I want to schedule tasks for user callbacks using the executor. Something like:

class ActionServer:
    ...
    self.node.executor.create_task(user_execute_callback)

But, without this change self.node.executor is None (which I presume is a bug).

@jacobperron jacobperron mentioned this pull request Feb 13, 2019
@jacobperron
Copy link
Copy Markdown
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 4028bc6 into master Feb 13, 2019
@jacobperron jacobperron deleted the fix_node_executor_prop branch February 13, 2019 18:03
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Feb 13, 2019
@jacobperron jacobperron mentioned this pull request Feb 15, 2019
10 tasks
jacobperron added a commit that referenced this pull request Mar 7, 2019
Previously, if a `Node` was added to an `Executor` using the executors `add_node` method, then nodes `executor` property would return `None`.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
nuclearsandwich pushed a commit that referenced this pull request Mar 10, 2019
* Add Action Client (#262)

* Add rclpy_action module

With functions for creating and destroying action clients.

* Implement action client

* Move common conversion function and typedefs to shared header file (impl/common.h)

* Add tests using mock action server

* Add action module for aggregating action related submodules

* Extend Waitable API so executors are aware of Futures

* Move check_for_type_support() to its own module

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Fix Executor not executing tasks if there are no ready entities in the wait set (#272)

If a task is created, then trigger the Executors guard condition. This will wake any blocking call to `rcl_wait()`.
In this scenario, no work is yielded, so we also have to move the check for 'in-progress' tasks into the wait loop.

Added a unit test to reproduce the issue.

This resolves an issue in some cases where the result response from the action server is never processed, therefore never reaching the action client.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Fix Node's reference to executor (#275)

Previously, if a `Node` was added to an `Executor` using the executors `add_node` method, then nodes `executor` property would return `None`.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Abstract type conversions into functions (#269)

* Abstract type conversions into functions

This helps with readability and maintainability.
Also eliminated use of assertions during conversions, defering to exceptions.

* Move common C functions to a shared library 'rclpy_common'

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add ActionServer (#270)

* Add Action server functions to extension module
    * Separated service related macros into separate request and response calls
* Add server goal handle functions to extension module
* Update Action extension module to use conversion functions
* Add implementation of Python ActionServer
    * Handles goal and cancel requests, responds, and calls user-defined functions for executing goals.
    * Handle result requests
    * Handle expired goals
    * Publish goal status array and feedback
* Add `handle_accepted_callback` to ActionServer

Upon accepting a goal, the provided `handle_accepted_callback` is called with a reference to the goal handle.
The user can then decide to execute the goal or defer.
If `handle_accepted_callback` is not provided, then the default behavior is to execute the goal handle immediately.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Enable test using MultiThreadedExecutor (#280)

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Guard against failed take when taking action messages (#281)

Some middlewares (e.g. Connext and OpenSplice) send invalid messages to indicate an instance has been disposed which results in a 'failed take'.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants