Skip to content

Add Waitable to callback group#265

Merged
jacobperron merged 1 commit intomasterfrom
bugfix_waitable_mutex
Jan 25, 2019
Merged

Add Waitable to callback group#265
jacobperron merged 1 commit intomasterfrom
bugfix_waitable_mutex

Conversation

@jacobperron
Copy link
Copy Markdown
Member

Resolves #264

This fixes an assertion error that occurs if a Waitable is used with a MutuallyExclusiveCallbackGroup.
Added a unit test to cover this case.

This fixes an assertion error that occurs if a Waitable is used with a MutuallyExclusiveCallbackGroup.
Added a unit test to cover this case.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Jan 25, 2019
@jacobperron
Copy link
Copy Markdown
Member Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jan 25, 2019
Copy link
Copy Markdown
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want @sloretz's approval too though.

@jacobperron jacobperron merged commit 737fd47 into master Jan 25, 2019
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Jan 25, 2019
@jacobperron jacobperron deleted the bugfix_waitable_mutex branch January 25, 2019 01:33
YuanYuYuan pushed a commit to YuanYuYuan/rclpy that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Waitable cannot be used with MutuallyExclusiveCallbackGroup

3 participants