Skip to content

Python thing that adds things to the wait set#250

Merged
sloretz merged 7 commits intomasterfrom
waitable_rclpy
Nov 26, 2018
Merged

Python thing that adds things to the wait set#250
sloretz merged 7 commits intomasterfrom
waitable_rclpy

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Nov 21, 2018

Python equivalent of ros2/rclcpp#589

@sloretz sloretz added the in progress Actively being worked on (Kanban column) label Nov 21, 2018
@sloretz sloretz added this to the crystal milestone Nov 21, 2018
@sloretz sloretz self-assigned this Nov 21, 2018
@sloretz sloretz added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 21, 2018
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 21, 2018

  • Linux Build Status
  • Linux-aarch64 Build Status

These failed due to jenkins issues, re-running

  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 22, 2018

WIndows Build Status

OSX Build Status

@sloretz sloretz merged commit e05892e into master Nov 26, 2018
@sloretz sloretz deleted the waitable_rclpy branch November 26, 2018 17:27
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Nov 26, 2018
@sloretz sloretz mentioned this pull request Nov 27, 2018
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants