Skip to content

Fixes memory leaks for nested fields#203

Merged
dirk-thomas merged 4 commits intoros2:masterfrom
martins-mozeiko:fix-memory-leaks
Jul 12, 2018
Merged

Fixes memory leaks for nested fields#203
dirk-thomas merged 4 commits intoros2:masterfrom
martins-mozeiko:fix-memory-leaks

Conversation

@martins-mozeiko
Copy link
Copy Markdown
Contributor

@martins-mozeiko martins-mozeiko commented Jul 11, 2018

This separates memory allocation out from convert_from_py function. Now it uses separate create_message function to allocate message, making it explicit gives better control where and how memory is allocated and freed.

See ros2/rosidl_python#5 for details.

This pull request depends on changes in ros2/rosidl_python#7

connects to ros2/rosidl_python#7

This separates memory allocation out from convert_from_py function.
Now it uses separate create_message function to allocate message,
making it explicit gives better control where and how memory is
allocated and freed.
@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jul 11, 2018
@mikaelarguedas mikaelarguedas mentioned this pull request Jul 12, 2018
13 tasks
dirk-thomas
dirk-thomas previously approved these changes Jul 12, 2018
@dirk-thomas dirk-thomas dismissed their stale review July 12, 2018 20:46

More linter problems

@dirk-thomas dirk-thomas merged commit 98ad24a into ros2:master Jul 12, 2018
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jul 12, 2018
@dirk-thomas dirk-thomas mentioned this pull request Oct 25, 2018
34 tasks
YuanYuYuan pushed a commit to YuanYuYuan/rclpy that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants