Skip to content

CFT is only supported rmw_fastrtps and rmw_connextdds.#1611

Merged
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/issues/1609
Feb 17, 2026
Merged

CFT is only supported rmw_fastrtps and rmw_connextdds.#1611
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/issues/1609

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

Description

Fixes #1609

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Copy link
Copy Markdown
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Barry-Xu-2018 my major concern is why we did not detect this failure when we were doing #1531? i think CI should have failed with cyclonedds...

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

Pulls: #1611
Gist: https://gist.githubusercontent.com/fujitatomoya/b62c021db5fc27c27f1237b400c0bdf8/raw/162511a11ee0837106e7d9bfe72aac7259ae584f/ros2.repos
BUILD args: --packages-up-to rclpy
TEST args: --packages-select rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18208

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya requested a review from ahcorde February 17, 2026 08:47
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

@Barry-Xu-2018 this is the cause of CI unstability, i will go ahead to merge this with @ahcorde 's approval.

@fujitatomoya fujitatomoya merged commit 73fb437 into rolling Feb 17, 2026
3 checks passed
@ahcorde ahcorde deleted the fujitatomoya/issues/1609 branch February 18, 2026 14:55
@Barry-Xu-2018
Copy link
Copy Markdown
Contributor

@Barry-Xu-2018 my major concern is why we did not detect this failure when we were doing #1531? i think CI should have failed with cyclonedds...

This is because there is no API available to determine whether RMW supports content filtering. Currently, the only way to confirm if content filtering is supported is to configure the content filter and then check whether the configuration takes effect.

I think it is better to add a new RMW API to return whether DDS supports content filtering. Currently, the tests skip unsupported DDS by hardcoding. If we have this RMW API, we just need to call the API before running the tests to decide whether to proceed. This way, once DDS supports content filtering later, we only need to change the return value of this API, and the relevant tests can run without modifying code in many places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🧑‍🌾 Rci__nightly-fastrtps/connext test_parameter_event_handler failing RCLerror

3 participants