CFT is only supported rmw_fastrtps and rmw_connextdds.#1611
CFT is only supported rmw_fastrtps and rmw_connextdds.#1611fujitatomoya merged 1 commit intorollingfrom
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
@Barry-Xu-2018 my major concern is why we did not detect this failure when we were doing #1531? i think CI should have failed with cyclonedds...
|
Pulls: #1611 |
|
@Barry-Xu-2018 this is the cause of CI unstability, i will go ahead to merge this with @ahcorde 's approval. |
This is because there is no API available to determine whether RMW supports content filtering. Currently, the only way to confirm if content filtering is supported is to configure the content filter and then check whether the configuration takes effect. I think it is better to add a new RMW API to return whether DDS supports content filtering. Currently, the tests skip unsupported DDS by hardcoding. If we have this RMW API, we just need to call the API before running the tests to decide whether to proceed. This way, once DDS supports content filtering later, we only need to change the return value of this API, and the relevant tests can run without modifying code in many places. |
Description
Fixes #1609
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information