Skip to content

Improve the compatibility of processing YAML parameter files (backport #1548)#1572

Merged
ahcorde merged 1 commit intokiltedfrom
mergify/bp/kilted/pr-1548
Dec 26, 2025
Merged

Improve the compatibility of processing YAML parameter files (backport #1548)#1572
ahcorde merged 1 commit intokiltedfrom
mergify/bp/kilted/pr-1548

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Dec 25, 2025

Description

Fixes #1546
And also supports the following YAML parameter format

/**/node_name:
   ros__parameters:
      ...
/*:
   node_name:
       ros__parameters:
          ...

Is this user-facing behavior change?

Yes. parameter_dict_from_yaml_file() supports a more complete parameter file format (consistent with rcl_yaml_param_parser).

Did you use Generative AI?

No

Additional Information

This is an automatic backport of pull request #1548 done by [Mergify](https://mergify.com).

@Barry-Xu-2018 @mergify
Improve the compatibility of processing YAML parameter files (#1548)
5f49f6e 
Signed-off-by: Barry Xu <barry.xu@sony.com>
(cherry picked from commit 8730916)
@mergify mergify bot mentioned this pull request Dec 25, 2025
Merged
fujitatomoya
fujitatomoya approved these changes Dec 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Dec 25, 2025

Pulls: #1572
Gist: https://gist.githubusercontent.com/fujitatomoya/51a22dca0d537cd9d69b427bd538a7a8/raw/4fa3ff31eb03ad90eaabcc4950fea278cc241a6a/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17845

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@Barry-Xu-2018
Copy link
Copy Markdown
Contributor

Barry-Xu-2018 commented Dec 25, 2025

Failed test cases

  • Linux

    • sros2.test.sros2.commands.security.verbs.test_generate_policy.test_generate_policy
      The reason for the test failure is not related to this PR.

  • Linux-rhel

    • sros2.test.sros2.commands.security.verbs.test_generate_policy.test_generate_policy
      The reason for the test failure is not related to this PR.

  • Windows
    There are more than a hundred failed tests. I will run the tests on the Windows platform again.
    Build Status

  • Linux-aarch64
    The problem was with the CI system. I have re-run the tests Build Status.
    Build Status

@ahcorde ahcorde merged commit 3119bd5 into kilted Dec 26, 2025
3 checks passed
@ahcorde ahcorde deleted the mergify/bp/kilted/pr-1548 branch December 26, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@Barry-Xu-2018 Barry-Xu-2018

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fujitatomoya @Barry-Xu-2018 @ahcorde