Stub type hash value line in TopicEndpointInfo string#1110
Merged
clalancette merged 2 commits intoros2:rollingfrom Apr 12, 2023
Merged
Stub type hash value line in TopicEndpointInfo string#1110clalancette merged 2 commits intoros2:rollingfrom
clalancette merged 2 commits intoros2:rollingfrom
Conversation
Part of ros2/ros2#1159 For use in backported ros2cli extension for first Iron-sync (post-release). Adding now for any parsers that expect constant format of this output Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
14 tasks
methylDragon
approved these changes
Apr 12, 2023
clalancette
approved these changes
Apr 12, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Contributor
|
CI:
|
Contributor
|
@emersonknapp It looks like there are a few tests that do indeed depend on the string output of the |
Collaborator
Author
|
Gist: https://gist.githubusercontent.com/emersonknapp/2b4855d50722980b55bf2168135ddc0f/raw/e59f254d411f3fcc064808e827865495be11ea15/ros2.repos
|
clalancette
approved these changes
Apr 12, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good with green CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ros2/ros2#1159
Enables #1104 and ros2/ros2cli#816 as backports for first Iron sync (post-release).
Adds extra line for "Topic type hash:" to string representation of
TopicEndpointInfo, in case any parsers expect specific format from that string.