-
Notifications
You must be signed in to change notification settings - Fork 278
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Milestone
Description
There is support for Clocks that use ROS Time as described in this design document. It was added in this PR.
Clocks can be set to have ROS time "active" (will use the value seen on the /clock topic as its time) by calling time_source.ros_time_is_active = True.
A node has a time source associated with it (added in #210). At the time of that PR, parameters were not available in rclpy, so the node's time source does not respond to the use_sim_time parameter:
Line 97 in 62012d3
| # TODO(dhood): use sim time if parameter has been set on the node. |
As of #214, parameters are available in rclpy.
Tasks to get rclpy nodes to respond to the use_sim_time parameter:
- Add a parameter callback that detects if
use_sim_timehas been set on the node. - Add tests that the node's clock output matches what's expected based on the combination of
use_sim_timeparameter and the presence of a/clockpublisher. These are the tests in rclcpp.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed