[Eloquent] Allow node clock use in logging macros#981
Merged
Conversation
Capturing a cached reference allows a clock object that is not a local (e.g. the one returned by Node::get_clock()) to be passed to the throttle logging macro. Signed-off-by: Matt Schickler <mschickler@gmail.com> Co-Authored-By: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
wjwwood
approved these changes
Feb 6, 2020
Contributor
Author
|
Merging without full CI since it's a cherry-pick backport (already passed CI once) and the PR job passed. |
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* support to publish as loaned message Signed-off-by: Barry Xu <barry.xu@sony.com> * Add option to enable loan message Signed-off-by: Barry Xu <barry.xu@sony.com> * Use disable-loan-message instead of enable-loan-message Signed-off-by: Barry Xu <barry.xu@sony.com> * Change to inner class and return code instead of exception Signed-off-by: Barry Xu <barry.xu@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #970 to ROS Eloquent