Skip to content

[dashing backport] Fixed error messages not printing to terminal (#777)#847

Merged
jacobperron merged 1 commit intodashingfrom
jacob/backport_777
Sep 5, 2019
Merged

[dashing backport] Fixed error messages not printing to terminal (#777)#847
jacobperron merged 1 commit intodashingfrom
jacob/backport_777

Conversation

@jacobperron
Copy link
Copy Markdown
Member

Backport #777

* Uncommented catch exception code to print error

Signed-off-by: Yathartha Tuladhar <yathartha3@gmail.com>

* put back the e

Signed-off-by: Yathartha Tuladhar <yathartha3@gmail.com>

* uncommented error printing in exception handling

Signed-off-by: Yathartha Tuladhar <yathartha3@gmail.com>

* Removed "/n" characters.
Update lifecycle_node_interface_impl.hpp

Signed-off-by: Yathartha Tuladhar <yathartha3@gmail.com>

* Fix CI issue and remove TODO

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Copy Markdown
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 25eeffd into dashing Sep 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/backport_777 branch September 5, 2019 18:59
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
* adds keyboard controls for ros2 bag play

Signed-off-by: Sonia Jin <diegothemuich@gmail.com>
Co-authored-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants