adding char * constructor for ParameterVarient #79
Merged
Conversation
rclcpp/include/rclcpp/parameter.hpp
Outdated
Member
There was a problem hiding this comment.
Please call the constructor with the std::string argument instead of reimplementing the same body.
Member
|
lgtm |
Member
|
+1 (including @dirk-thomas 's comment) |
…ted constructor
Contributor
Author
|
switched to delegating constructor. That's a neat new c++11 feature. |
Member
|
+1 (again) |
Member
|
+1 |
tfoote
added a commit
that referenced
this pull request
Aug 4, 2015
adding char * constructor for ParameterVarient
mauropasse
pushed a commit
to mauropasse/rclcpp
that referenced
this pull request
Feb 7, 2022
…estruction Add mutex to protect GuardCondition callback
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
fix no data handling
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
- for a shared library, no lib file is generated on Windows - needed for Linux to be included in shared libraries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #75