Replace 'auto' to 'const auto &' in for loops#629
Closed
youtalk wants to merge 1 commit intoros2:masterfrom
Closed
Replace 'auto' to 'const auto &' in for loops#629youtalk wants to merge 1 commit intoros2:masterfrom
youtalk wants to merge 1 commit intoros2:masterfrom
Conversation
Member
|
@youtalk did you intend to close this pull request? I think it makes sense and would start CI so it could be merged if you opened it again. |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
…#629) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found some call by value in the for loop codes but they are preferred to replace to call by reference.
This PR simply solves it.