Skip to content

remove dependency on rclpy from rclcpp_lifecycle#626

Merged
wjwwood merged 1 commit intomasterfrom
wjwwood-patch-1
Feb 6, 2019
Merged

remove dependency on rclpy from rclcpp_lifecycle#626
wjwwood merged 1 commit intomasterfrom
wjwwood-patch-1

Conversation

@wjwwood
Copy link
Copy Markdown
Member

@wjwwood wjwwood commented Feb 5, 2019

Not sure why it was there in the first place...

It has been there since the original commit adding lifecycle stuff.

Not sure why it was there in the first place...

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added enhancement New feature or request in review Waiting for review (Kanban column) labels Feb 5, 2019
@wjwwood wjwwood self-assigned this Feb 5, 2019
@wjwwood wjwwood requested a review from Karsten1987 February 5, 2019 02:24
Copy link
Copy Markdown
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it's there. makes total sense to remove.

@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Feb 5, 2019

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood merged commit c7ac39a into master Feb 6, 2019
@wjwwood wjwwood deleted the wjwwood-patch-1 branch February 6, 2019 00:02
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Feb 6, 2019
cho3 pushed a commit to cho3/rclcpp that referenced this pull request Jun 3, 2019
Not sure why it was there in the first place...

Signed-off-by: William Woodall <william@osrfoundation.org>
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants