Set Parameter Event Publisher settings #591#614
Merged
wjwwood merged 5 commits intoros2:masterfrom Feb 7, 2019
Merged
Conversation
jacobperron
reviewed
Jan 14, 2019
Member
jacobperron
left a comment
There was a problem hiding this comment.
Apologies for the delayed response.
Member
|
I went ahead and addressed the review comments and touched a few other things to move this along, thanks for the original changes @rarvolt! |
Member
|
CI:
|
wjwwood
approved these changes
Jan 17, 2019
jacobperron
approved these changes
Jan 17, 2019
Member
|
Looks like some things still need to be updated to use the new node signature, but I would like to defer until after this is merged: Which will make it much easier to do this pr without breaking downstream things, and merging this pr would break that one. |
…ettings Signed-off-by: RARvolt <rarvolt@gmail.com>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
cdeb8dd to
08a7ad8
Compare
Signed-off-by: William Woodall <william@osrfoundation.org>
Member
|
Ok, rebased and updated to use the @jacobperron do you have time to re-review this? |
Member
|
CI:
|
Signed-off-by: William Woodall <william@osrfoundation.org>
Member
|
CI after fixing lifecycle node constructor:
|
Member
|
Thanks for the contribution @rarvolt! |
cho3
pushed a commit
to cho3/rclcpp
that referenced
this pull request
Jun 3, 2019
* Add ability to disable Parameter Event Publisher and change its QoS settings Signed-off-by: RARvolt <rarvolt@gmail.com> * address review comments Signed-off-by: William Woodall <william@osrfoundation.org> * use NodeOptions struct Signed-off-by: William Woodall <william@osrfoundation.org> * remove vestigial doc strings and improve docs Signed-off-by: William Woodall <william@osrfoundation.org> * fix lifecycle node constructor Signed-off-by: William Woodall <william@osrfoundation.org>
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* Add support for taking a sequence of messages Signed-off-by: Michael Carroll <michael@openrobotics.org> * Fix uncrustify Signed-off-by: Michael Carroll <michael@openrobotics.org> * Apply suggestions from code review Co-Authored-By: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org> * Address reviewer feedback. Signed-off-by: Michael Carroll <michael@openrobotics.org> * Remove vertical whitespace Signed-off-by: Michael Carroll <michael@openrobotics.org> * Address reviewer feedback Signed-off-by: Michael Carroll <michael@openrobotics.org> * Remove blank line Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
…ion (ros2#624) * Add tests for the test_validate_enclave_name module * Add test that is failing * Add test that is failing * Fix function used for publishing * Fix function used for publishing * Fix serialize subscription test * Fix serialize subscription test * Add tests for loan msgs and get_options * Add tests for loan msgs and get_options * Add support for taking a sequence of messages (ros2#614) * Add support for taking a sequence of messages * Fix uncrustify * Apply suggestions from code review * Address reviewer feedback. * Remove vertical whitespace * Address reviewer feedback * Remove blank line * Remove extra character left when rebasing * Remove test used for debugging * Remove repeated tests * Add test for get_options * Fix uncrustify errors Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
…ing team (ros2#614) Signed-off-by: Emerson Knapp <eknapp@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to disable Parameter Event Publisher and to set its QoS mentioned in #591