issue a warning if publishing on a not active publisher#574
Merged
Karsten1987 merged 2 commits intoros2:masterfrom Oct 28, 2018
Merged
issue a warning if publishing on a not active publisher#574Karsten1987 merged 2 commits intoros2:masterfrom
Karsten1987 merged 2 commits intoros2:masterfrom
Conversation
Contributor
|
@fmrico thanks for patch. I believe the same comment for PR #552 applies here: |
…ating a new one echa call
Contributor
Author
|
Hi @Karsten1987 , I fixed it following the comments in #562 . Is was not so simple, because I had to change logging macros, to make it compile. Macro has changed to: adding I run the tests and everything worked ok. Best |
Contributor
Karsten1987
approved these changes
Oct 28, 2018
Contributor
Author
|
Thanks @Karsten1987 !!! |
|
Great @fmrico 💪 |
cho3
pushed a commit
to cho3/rclcpp
that referenced
this pull request
Jun 3, 2019
* issue a warning if publishing on a not active publisher * Adding a logger private member in LifecyclePublisher for avoiding creating a new one echa call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
Issue #552 seems to be blocked. @Myzhar did not a PR with his work. This is a PR with his changes.
This PR provides the machanism to issue a WARN when publishing on a not active publisher.
Best