Add SMART_PTRS_DEF to LifecyclePublisher#569
Merged
Karsten1987 merged 1 commit intoros2:masterfrom Oct 12, 2018
Merged
Conversation
Karsten1987
approved these changes
Oct 12, 2018
Contributor
Karsten1987
left a comment
There was a problem hiding this comment.
lgtm, thanks for the patch.
for future references, you can add fixes followed by the link to your github issue to connect them. This will automatically close the issue the moment the PR gets merged.
I went ahead and modified your original message of this PR to give you an example.
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
ros2#569) Signed-off-by: y-okumura-isp <y-okumura@isp.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #568