Add virtual destructors to classes with virtual functions.#566
Merged
clalancette merged 1 commit intomasterfrom Oct 8, 2018
Merged
Add virtual destructors to classes with virtual functions.#566clalancette merged 1 commit intomasterfrom
clalancette merged 1 commit intomasterfrom
Conversation
This fixes the build on MacOS High Sierra and later, and is the more correct thing to do anyway. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
CI:
|
This was referenced Oct 8, 2018
Merged
dirk-thomas
approved these changes
Oct 8, 2018
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Update changelogs and setup.py Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org> * Update versions in new packages to match (so that we can run bloom) Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org> * 0.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the build on MacOS High Sierra and later, and
is the more correct thing to do anyway.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
fixes #563