Conversation
dirk-thomas
approved these changes
Aug 31, 2018
Member
Author
|
CI (since I actually touched code):
|
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Borja Outerelo <borjaouterelo@gmail.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Double buffers Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Circular queue and FLUSH option as define Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Minor naming and lexical fixes. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Removed FLUSH_BUFFERS define check. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Sqlite3 storage logging fixes. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Sqlite3 storage circular buffer with pre allocated memory. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Sqlite3 storage buffers moved to shared_ptrs. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Uncrustify Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Moved double buffers to writer Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Buffer layer reset in seq compression writer in rosbag2 cpp Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Buffer layer for rosbag2 writer refactor Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Changed buffers in BufferLayer to std vectors. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * BufferLayer uncrustify Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Removed non-applicable test for writer cache. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * BufferLayer review fixes Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Rosbag metadata msgs count fixed for BufferLayer Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Condition variable for buffer layer sync. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Fixed buffer locks Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Buffers in BufferLayer refactored, moved into new class Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Buffer layer split bags fixed. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Storage options include fix in buffer layer header. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Mutex around swapping buffers in buffer layer. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Fixed cache 0 bug in buffer layer. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Minor buffer layer refactor. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Counting messages in writer refactored. Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> * Changed default cache size to 100Mb and updated parameter description Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * Applied review remarks: - significant refactoring: separation of cache classes - applied suggested improvements - some renaming - reduce code duplication that would otherwise increase with cache refactor, between compression and plain writers Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * Applied review comments - cache consumer now takes a callback and is independent of storage - namespace changes, renaming, cleaning - counting and logging messages by topic Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * linter Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * Changes after review: fixing flushing, topic counts, and more Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * Fix for splitting - flushing state now correctly turns off Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * cache classes documentation Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * simplified signature Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * a couple of tests for cache Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * address review: explicit constructor and doxygen styling Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * Windows warnings fix Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * fixed type mismatch warning on Windows Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * added minor comment Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> Co-authored-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some issues raised by doxygen that were pointed out to me.