Conversation
tfoote
approved these changes
Jul 27, 2018
dirk-thomas
reviewed
Jul 27, 2018
| rcl_time_point_value_t | ||
| nanoseconds() const; | ||
|
|
||
| /// \return the seconds since epoch as a floating point number. |
Member
There was a problem hiding this comment.
Should the docblock contain a note/warning about potential rounding errors? I think that was one reason to omit the function until now.
dirk-thomas
approved these changes
Jul 27, 2018
* construct TimerBase/GenericTimer with Clock * pass rcl_time_point_value_t to rcl_clock_get_now * update docblocks
Contributor
Author
|
Thanks for the reviews. CI in ros2/geometry2#67 (comment) looks green, so I'll merge this. |
7 tasks
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
…est (ros2#526) Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(edit) #482Edit oops, this doesn't fix 482. That ticket is about duration types.This adds
seconds()which returns the seconds since epoch as a double.Connects to ros2/geometry2#67