Merged
Conversation
Karsten1987
added a commit
that referenced
this pull request
Jun 16, 2018
* publish_raw function * subscription traits * listener raw * rebased * cleanup and linters * explicit test for deleter in unique_ptr * add missing copyright * cleanup * add rmw_serialize functions * linters * explicit differentiation between take and take_raw * cleanup debug messages * rename to rmw_message_init` * address comments * address review comments * raw->serialized * use size_t (#497)
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* Polish rcl arguments implementation. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Improve debug logging messages. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* read yaml config file Signed-off-by: Karsten Knese <karsten@openrobotics.org> * address review comments Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * Sqlite storage pragmas handling and validation - includes documentation of storage-config-file option - includes adaptation of benchmarking script to cache size semantic change - tests with valid and invalid storage file Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * Applied review remarks Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * - Typo fix - change pragma tests order as a workaround to fix tests issue on Windows: exception throwing tests don't clean temp folders Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * Applied review: moved some parsing and key extraction to parse function Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> Co-authored-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to ros2/demos#185