add missing set_parameters_atomically client#494
Merged
mikaelarguedas merged 1 commit intomasterfrom Jun 11, 2018
Merged
Conversation
tfoote
approved these changes
Jun 11, 2018
Contributor
tfoote
left a comment
There was a problem hiding this comment.
lgtm, in early generations I believe there was discussion of only allowing atomic operations locally etc, but if we have the server side we should definitely have the client available.
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* Treat __name the same as __node This modifies the lexer so that it will accept __name and treat it exactly the same as __node. __node still works in order to preserve backwards compatibility. Fixes ros2#258 Distribution Statement A; OPSEC ros2#2893 Signed-off-by: P. J. Reed <preed@swri.org> * Update dot graph for lexer Distribution Statement A; OPSEC ros2#2893 Signed-off-by: P. J. Reed <preed@swri.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter server creates the following service servers:
The parameter client creates all but
set_parameters_atomically.Is it intentional ?
Assuming it's not, this PR adds the missing one.
Leaving this in progress until CI comes back green