Revert "Store the subscriber, client, service and timer"#448
Merged
Conversation
This reverts commit 3652646.
wjwwood
added a commit
that referenced
this pull request
Mar 14, 2018
wjwwood
added a commit
that referenced
this pull request
Mar 20, 2018
* Revert "Revert "Store the subscriber, client, service and timer (#431)" (#448)" This reverts commit 168d75c. * Convert all rcl_*_t types to shared pointers Converts all rcl_*_t types in the memory allocation strategy to shared pointers to prevent crash happening when a subscriber is reset. Issue: #349 * fixups
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
…s2#448) * user friendly error messages for invalid transitions Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #431
Unfortunately this caused a regression in our tests that I misinterpreted as unrelated, see: ros2/build_farmer#96 (comment)
@guillaumeautran and @deng02 FYI. I'll open a revert of this revert after merging where we can discuss the way to get that test passing again.