Conversation
2 tasks
Member
|
I am leaning towards the first option since imo the second one keeps adding more and more API to the node / interfaces (which I am not a big fan of). But I don't mind either way and would let others comment on this which are more familiar with the pros / cons of the two options. |
Member
|
Option 3? Provide the |
Member
Author
|
waiting for review @ros2/team |
Karsten1987
approved these changes
Feb 21, 2018
Contributor
Karsten1987
left a comment
There was a problem hiding this comment.
this looks good to me. You may want to have an approval from @dirk-thomas or @wjwwood though.
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Miaofei <miaofei@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects to ros2/rcl#212
I have a question on this PR. Which approach is more appropriate in the context of node interfaces:
It's not clear to me since on one hand the logger name is used (only) by the logging interface, but on the other hand at the rcl level it is tightly coupled to what seems to be the node "base".