Move clear wait set from after rcl_wait to ahead#427
Merged
wjwwood merged 2 commits intoros2:masterfrom Jan 19, 2018
Merged
Conversation
Current code clear wait set after rcl_wait, it is not respond latency friendly. In fact, clear wait set operation is not urgent, making sure it is done before next rcl_wait should be fine. Signed-off-by: jwang <jing.j.wang@intel.com>
wjwwood
approved these changes
Jan 12, 2018
Member
wjwwood
left a comment
There was a problem hiding this comment.
This seems reasonable to me, anyone else object?
Member
|
I'm combining the CI for this pr and ros2/rcl#207:
|
Member
|
Before the |
Member
|
I would say no, since it only prepares the storage to be used in a repeated loop, it doesn't clean up any resources or anything. It's analogous to memset to zero. The docs reflect this as well: |
Member
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Improve help message for CLI verbs Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Apply suggestion from review Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current code do clear wait set after rcl_wait, it is not respond latency
friendly. In fact, clear wait set operation is not urgent, making sure it is
done before next rcl_wait should be fine. With this commit, ready task
will get executed more quickly
Signed-off-by: jwang jing.j.wang@intel.com