remove patch_and_return to right before where it is necessary.#3042
remove patch_and_return to right before where it is necessary.#3042jmachowinski merged 1 commit intorollingfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky test by moving the mock setup to the correct location. The test TestExecutor.spin_all_fail_wait_set_clear was failing intermittently because the mock for rcl_wait_set_clear was installed too early, potentially interfering with the first spin_all call depending on whether the wait set needed resizing.
Changes:
- Moved the
patch_and_returncall forrcl_wait_set_clearfrom before the firstspin_allto between the first and secondspin_allcalls, ensuring the mock only affects the intended second call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com>
7ffcf88 to
d41b15d
Compare
|
Pulls: #3042
|
|
@Mergifyio backport kilted |
✅ Backports have been createdDetails
|
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> (cherry picked from commit 5ac7f1f)
Description
Possible fix for #2926.
I cannot verify this PR to see if it fixes the issue, because i do not have reproducible environment.
Fixes # (issue)
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information