Skip to content

remove I/O from signal handler. (backport #2986)#2997

Closed
mergify[bot] wants to merge 1 commit intohumblefrom
mergify/bp/humble/pr-2986
Closed

remove I/O from signal handler. (backport #2986)#2997
mergify[bot] wants to merge 1 commit intohumblefrom
mergify/bp/humble/pr-2986

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Nov 21, 2025

Description

Fixes #2982

Is this user-facing behavior change?

Yes this fixes the possible deadlock via IO.

Did you use Generative AI?

No.

Additional Information

Note

backport required for all downstream distros.


This is an automatic backport of pull request #2986 done by Mergify.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 95cb964)

# Conflicts:
#	rclcpp/src/rclcpp/signal_handler.hpp
@mergify mergify bot added the conflicts label Nov 21, 2025
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Nov 21, 2025

Cherry-pick of 95cb964 has failed:

On branch mergify/bp/humble/pr-2986
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 95cb964.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rclcpp/src/rclcpp/signal_handler.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/src/rclcpp/signal_handler.hpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@fujitatomoya
Copy link
Copy Markdown
Collaborator

Pulls: #2997, ros2/system_tests#579
Gist: https://gist.githubusercontent.com/fujitatomoya/4156c614cc97df073544dde75d126a05/raw/0de0fe940cfc63ec74505be2877d58f0c3796c6f/ros2.repos
BUILD args: --packages-above-and-dependencies ‎rclcll test_rclcpp
TEST args: --packages-above ‎rclcll test_rclcpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17563

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

Pulls: #2997, ros2/system_tests#579
Gist: https://gist.githubusercontent.com/fujitatomoya/10856f381df425ff08b16b76b0544520/raw/0de0fe940cfc63ec74505be2877d58f0c3796c6f/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp test_rclcpp
TEST args: --packages-above rclcpp test_rclcpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17566

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski
Copy link
Copy Markdown
Collaborator

API/ABI break

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@jmachowinski thank you so much 👍 what was i thinking ... 😓 This is an ABI break. Any binaries built against the old version must be recompiled, i will close all backports.

@fujitatomoya
Copy link
Copy Markdown
Collaborator

This is ABI breaking change, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants