remove I/O from signal handler. (backport #2986)#2997
remove I/O from signal handler. (backport #2986)#2997mergify[bot] wants to merge 1 commit intohumblefrom
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 95cb964) # Conflicts: # rclcpp/src/rclcpp/signal_handler.hpp
|
Cherry-pick of 95cb964 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Pulls: #2997, ros2/system_tests#579 |
|
Pulls: #2997, ros2/system_tests#579 |
|
API/ABI break |
|
@jmachowinski thank you so much 👍 what was i thinking ... 😓 This is an ABI break. Any binaries built against the old version must be recompiled, i will close all backports. |
|
This is ABI breaking change, closing. |
Description
Fixes #2982
Is this user-facing behavior change?
Yes this fixes the possible deadlock via IO.
Did you use Generative AI?
No.
Additional Information
Note
backport required for all downstream distros.
This is an automatic backport of pull request #2986 done by Mergify.