Skip to content

Allow for implicitly convertable loggers as well (backport #2922)#2936

Merged
jmachowinski merged 1 commit intoros2:kiltedfrom
nobleo:feature/multiple-logger-implementations-kilted
Aug 18, 2025
Merged

Allow for implicitly convertable loggers as well (backport #2922)#2936
jmachowinski merged 1 commit intoros2:kiltedfrom
nobleo:feature/multiple-logger-implementations-kilted

Conversation

@Timple
Copy link
Copy Markdown
Contributor

@Timple Timple commented Aug 14, 2025

Description

This way I can inherit from rclpp::Logger and still pass it to the logger macros.

Is this user-facing behavior change?

Backwards compatible

Did you use Generative AI?

No

Additional Information

If accepted I would like to have this backported to active distros as well.

This is a manual backport of pull request #2922 done by @Timple.

@Timple
Allow for implicitly convertable loggers as well (ros2#2922)
6d6332f 
Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
@jmachowinski
Copy link
Copy Markdown
Collaborator

jmachowinski commented Aug 14, 2025

Pulls: #2936
Gist: https://gist.githubusercontent.com/jmachowinski/e0cde8cce5326dac368acddb84076d72/raw/960422ed2ad042b1b008aebfa4614ea0c36b9e3b/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16707

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Aug 14, 2025

Pulls: #2936
Gist: https://gist.githubusercontent.com/fujitatomoya/ca77ee7e0b7049bc6df74e2c1c60da09/raw/82aae5507f0c410998d049330f68df77688462be/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16708

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Aug 14, 2025

CI should be started with kilted but rolling.

@Timple
Copy link
Copy Markdown
Contributor Author

Timple commented Aug 18, 2025

Why did I get assigned? Is there any action for me to take? Note, I don't have merge rights here.

@jmachowinski jmachowinski merged commit 8a4cb48 into ros2:kilted Aug 18, 2025
2 of 3 checks passed
@jmachowinski
Copy link
Copy Markdown
Collaborator

jmachowinski commented Aug 18, 2025

@Mergifyio backport jazzy humble

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 18, 2025 •
edited
Loading

backport jazzy humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Aug 18, 2025
@Timple @mergify
Allow for implicitly convertable loggers as well (#2922) (#2936)
e9bee01 
Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
(cherry picked from commit 8a4cb48)
mergify bot pushed a commit that referenced this pull request Aug 18, 2025
@Timple @mergify
Allow for implicitly convertable loggers as well (#2922) (#2936)
671214f 
Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
(cherry picked from commit 8a4cb48)
This was referenced Aug 18, 2025
Merged
Merged
fujitatomoya pushed a commit that referenced this pull request Aug 19, 2025
@mergify @Timple
Allow for implicitly convertable loggers as well (#2922) (#2936) (#2937)
2096d63 
(cherry picked from commit 8a4cb48)

Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl>
jmachowinski pushed a commit that referenced this pull request Aug 19, 2025
@mergify @Timple
Allow for implicitly convertable loggers as well (#2922) (#2936) (#2938)
443b69b 
(cherry picked from commit 8a4cb48)

Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmachowinski jmachowinski jmachowinski approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@Timple Timple

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Timple @jmachowinski @fujitatomoya